Fix #13522 FP knownConditionTrueFalse after unsigned-to-signed conversion #7179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pfultz2 Any thoughts? |
danmar
reviewed
Jan 5, 2025
pfultz2
reviewed
Jan 7, 2025
| @@ -527,6 +527,8 @@ struct ValueFlowAnalyzer : Analyzer { | |||
| continue; | |||
| if (exact && v.intvalue != 0 && !isPoint) | |||
| continue; | |||
| if (astIsUnsigned(tok) != astIsUnsigned(v.tokvalue)) | |||
There was a problem hiding this comment.
This is fine, it is a little too restrictive which could lead to FNs, but it will fix FPs. To fix FNs, we would need to check if the value is within the range of an unsigned value. I am not sure how to write a test case to demonstrate it though as most known values will be passed through with the afterAssign passes anyways. Need to think about it some more.
There was a problem hiding this comment.
👍 We could also wait until after the next release, so we can see the effects in daca.
firewave
added
the
merge-after-next-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.